Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward original errors in multitest instantiate, execute and query #656

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

maurolacy
Copy link
Contributor

Instead of rewriting errors, just forward them so that they can be used for error matching / patterns.

Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You basically get rid of annotation "Contract returned an error..." or is something more sophisticated going on here?

@maurolacy
Copy link
Contributor Author

You basically get rid of annotation "Contract returned an error..." or is something more sophisticated going on here?

Just that. If not, we cannot pattern / text match the original errors anymore; which is useful for tests.

@maurolacy maurolacy merged commit 278552d into main Feb 14, 2022
@maurolacy maurolacy deleted the fix/forward-contract-errors branch February 14, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants