Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update storage plus docs / Remove MultiIndex PK default #671

Merged
merged 8 commits into from
Feb 24, 2022
Merged

Update storage plus docs / Remove MultiIndex PK default #671

merged 8 commits into from
Feb 24, 2022

Conversation

maurolacy
Copy link
Contributor

Closes #669.

ueco-jb
ueco-jb approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@ueco-jb ueco-jb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
I salute you for your commitment, since this PR could be a one liner after all.

packages/storage-plus/README.md Show resolved Hide resolved
packages/storage-plus/README.md Show resolved Hide resolved
packages/storage-plus/README.md Outdated Show resolved Hide resolved
packages/storage-plus/README.md Outdated Show resolved Hide resolved
@maurolacy maurolacy merged commit 33be660 into main Feb 24, 2022
@maurolacy maurolacy deleted the 669-update-storage-plus-docs branch February 24, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueco-jb ueco-jb ueco-jb approved these changes

@uint uint Awaiting requested review from uint

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

@hashedone hashedone Awaiting requested review from hashedone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix MultiIndex last type param default / docs
2 participants
@maurolacy @ueco-jb