Fix cw20 ics20 packets #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giansalex
reviewed
Mar 24, 2022
| for (denom, mut state) in states.into_iter() { | ||
| // this checks if we have received some coins that are "in flight" and not yet accounted in the state | ||
| let Coin { amount, .. } = deps.querier.query_balance(addr, &denom)?; | ||
| let diff = state.outstanding - amount; |
There was a problem hiding this comment.
Suggested change
| let diff = state.outstanding - amount; | |
| let diff = amount - state.outstanding; |
should be: cw-balance > state.outstanding ?
There was a problem hiding this comment.
Good catch! This is why I need tests (to panic here), or good reviewers
There was a problem hiding this comment.
still missing the handling for cw20 tokens...
There was a problem hiding this comment.
Done in 9ad5fef but not sure how to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #662
We change the logic to always be the "v2" style, and no longer add a flag in the packet (which is rejected by the transfer module), but rather migrate current state to new format if possible (for 1 open channel, we can assign all current balance to inflight for this channel).
If there are production versions that have multiple open channels and need migration, please comment here, and we could possibly support that migration in the future (but it is much trickier).
cc: @giansalex
TODO: add a test for the migration code