Multisig status logic #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
force-pushed
the
677-status-logic
branch
2 times, most recently
from
4d1f7a1
to
3f6f2a6
Compare
0xekez
reviewed
Aug 22, 2022
0xekez
reviewed
Aug 22, 2022
hashedone
approved these changes
Aug 23, 2022
Backported from flex-multisig
maurolacy
force-pushed
the
677-status-logic
branch
from
84d844e
to
9494ad7
Compare
This was referenced Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #677. This bug only affects fixed-multisig, as it was already fixed in flex-multisig.
Fixes a related / similar bug in both multisigs, in which a
Passed(due to expiration) proposal could still beClosedafter expiration.