Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for cw3-fixed-multisig #95

Merged
merged 15 commits into from
Sep 27, 2020
Merged

Unit tests for cw3-fixed-multisig #95

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a08883c
Basic unit tests for init, propose, and vote
maurolacy Sep 24, 2020
5419b0f
Add voter() helper, setup_test_case() refactor
maurolacy Sep 26, 2020
0b4e75e
Add init() consistency / validity checks
maurolacy Sep 26, 2020
dd99863
propose() checks / tests
maurolacy Sep 26, 2020
8b08418
Add response event attributes
maurolacy Sep 26, 2020
62beab9
vote() tests
maurolacy Sep 26, 2020
e4c2abe
execute() tests
maurolacy Sep 26, 2020
a940f54
close() tests
maurolacy Sep 26, 2020
4d2c829
Fail if expiration options not comparable
maurolacy Sep 26, 2020
ebc8c6d
No/Veto votes tests
maurolacy Sep 27, 2020
f979892
non-Open cannot be voted
maurolacy Sep 27, 2020
210f896
Allow zero weights
maurolacy Sep 27, 2020
e664328
Proposal from sender with enough vote power passes
maurolacy Sep 27, 2020
5e948fd
Expired proposals cannot be voted
maurolacy Sep 27, 2020
587c958
Add extra close() tests in passing
maurolacy Sep 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions contracts/cw3-fixed-multisig/src/contract.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,7 @@ mod tests {
const VOTER2: &str = "voter0002";
const VOTER3: &str = "voter0003";
const VOTER4: &str = "voter0004";
const VOTER5: &str = "voter0005";
const SOMEBODY: &str = "somebody";

fn voter<T: Into<HumanAddr>>(addr: T, weight: u64) -> Voter {
Expand All @@ -501,6 +502,7 @@ mod tests {
voter(VOTER2, 2),
voter(VOTER3, 3),
voter(VOTER4, 4),
voter(VOTER5, 5),
];

let init_msg = InitMsg {
Expand Down Expand Up @@ -792,7 +794,7 @@ mod tests {

// Vote it again, so it passes
let env = mock_env(VOTER4, &[]);
let res = handle(&mut deps, env, yes_vote).unwrap();
let res = handle(&mut deps, env, yes_vote.clone()).unwrap();

// Verify
assert_eq!(
Expand All @@ -809,7 +811,17 @@ mod tests {
}
);

// TODO: non-Open proposals cannot be voted
// non-Open proposals cannot be voted
// Vote it again
let env = mock_env(VOTER5, &[]);
let res = handle(&mut deps, env, yes_vote);
Copy link
Contributor Author

@maurolacy maurolacy Sep 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding this test, I was left wondering that maybe it's a good idea to allow voting on Passed proposals: https://github.com/CosmWasm/cosmwasm-plus/blob/f979892bb7d32339769ad83ccb289e92e5a2f300/contracts/cw3-fixed-multisig/src/contract.rs#L165

That way, we can get better statistics on the final result of a given proposal. That is, despite a proposal having passed, it can have a large number of No / Veto votes (some of which could have been cast after it passed). Or, conversely, a proposal can have a larger adoption than the one reflected by the results; which currently "freeze" after it passes.


// Verify
assert!(res.is_err());
match res.unwrap_err() {
StdError::GenericErr { msg, .. } => assert_eq!(&msg, "Proposal is not open"),
e => panic!("unexpected error: {}", e),
}

// TODO: expired proposals cannot be voted
}
Expand Down