Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IndexedMap constructor function const #22

Merged
merged 4 commits into from Dec 6, 2022
Merged

Make IndexedMap constructor function const #22

merged 4 commits into from Dec 6, 2022

Conversation

larry0x
Copy link
Contributor

@larry0x larry0x commented Dec 2, 2022

Makes the following functions constant:

  • IndexedMap::new
  • MultiIndex::new
  • UniqueIndex::new

ueco-jb
ueco-jb approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
👍 for tests improvements

ethanfrey
ethanfrey approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like good cleanup.

It doesn't break anything, but allows new use cases.
I guess the Rust compiler just got smarter since the code was written.

@webmaster128 webmaster128 reopened this Dec 6, 2022
@webmaster128
Copy link
Member

"Build forked pull requests" was off in the circleci config for this project. I now turned it on and re-opened to trigger a build.

@ueco-jb ueco-jb merged commit a45379e into CosmWasm:main Dec 6, 2022
@larry0x larry0x deleted the const-new-fns branch December 6, 2022 16:03
@adairrr adairrr mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueco-jb ueco-jb ueco-jb approved these changes

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larry0x @webmaster128 @ethanfrey @ueco-jb