Fixing shellcheck issues

CosmWasm · Apr 25, 2022 · 77a0cac · 77a0cac
1 parent 312c12e
commit 77a0cac
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -40,7 +40,7 @@ with `cosmwasm-plus`, or with a sample app from `cosmwasm-template`.
 SSH credentials for fetching private repo dependencies can be configured through environment variable `GIT_CREDENTIALS` 
 
 ```sh
-docker run -e GIT_CREDENTIALS=https://githuser:<TOKEN>@github.com --rm -v "$(pwd)":/code \
+docker run -e GIT_CREDENTIALS=https://<githuser>:<token>@github.com --rm -v "$(pwd)":/code \
  --mount type=volume,source="$(basename "$(pwd)")_cache",target=/code/target \
  --mount type=volume,source=registry_cache,target=/usr/local/cargo/registry \
  cosmwasm/rust-optimizer:0.12.6

diff --git a/optimize.sh b/optimize.sh
@@ -4,7 +4,7 @@
 set -o errexit -o nounset -o pipefail
 command -v shellcheck >/dev/null && shellcheck "$0"
 
-[ ! -z "$GIT_CREDENTIALS" ] && echo $GIT_CREDENTIALS >~/.git-credentials && git config --global credential.helper store
+[ -n "${GIT_CREDENTIALS=""}" ] && echo "$GIT_CREDENTIALS" >~/.git-credentials && git config --global credential.helper store
 export PATH=$PATH:/root/.cargo/bin
 
 # Suffix for non-Intel built artifacts

diff --git a/optimize_workspace.sh b/optimize_workspace.sh
@@ -4,7 +4,7 @@
 set -o errexit -o nounset -o pipefail
 command -v shellcheck >/dev/null && shellcheck "$0"
 
-[ ! -z "$GIT_CREDENTIALS" ] && echo $GIT_CREDENTIALS >~/.git-credentials && git config --global credential.helper store
+[ -n "${GIT_CREDENTIALS:=""}" ] && echo "$GIT_CREDENTIALS" >~/.git-credentials && git config --global credential.helper store
 export PATH="$PATH:/root/.cargo/bin"
 
 # Suffix for non-Intel built artifacts