Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed panics in deserialize to errors. #137

Merged
merged 1 commit into from
May 25, 2023
Merged

Changed panics in deserialize to errors. #137

merged 1 commit into from
May 25, 2023

Conversation

jawoznia
Copy link
Collaborator

Made them more descriptive
close #118

Made them more descriptive
@jawoznia jawoznia requested a review from hashedone May 24, 2023 19:48
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #137 (90c2876) into main (0f4ca15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   79.86%   79.86%           
=======================================
  Files          33       33           
  Lines        1733     1733           
=======================================
  Hits         1384     1384           
  Misses        349      349           
Impacted Files Coverage Δ
sylvia-derive/src/message.rs 74.92% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawoznia jawoznia merged commit 41f1378 into main May 25, 2023
@jawoznia jawoznia deleted the remove_panics branch May 25, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove panics from Deserialize
2 participants