Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BoundQuerier improve #321

Merged
merged 1 commit into from
Mar 11, 2024
Merged

feat: BoundQuerier improve #321

merged 1 commit into from
Mar 11, 2024

Conversation

kulikthebird
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.45%. Comparing base (9f13d09) to head (6a4136d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   85.43%   85.45%   +0.01%     
==========================================
  Files          37       37              
  Lines        2692     2695       +3     
==========================================
+ Hits         2300     2303       +3     
  Misses        392      392              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kulikthebird kulikthebird added this to the 1.0.0 milestone Mar 5, 2024
@kulikthebird kulikthebird force-pushed the feat/remove_contract_module_support branch from 0e6a870 to 6be2706 Compare March 5, 2024 13:44
@kulikthebird kulikthebird force-pushed the feat/bound_querier_improve branch from 8a414ea to c4f7bd9 Compare March 5, 2024 13:45
@kulikthebird kulikthebird force-pushed the feat/remove_contract_module_support branch from 6be2706 to 927ce26 Compare March 5, 2024 13:48
@kulikthebird kulikthebird force-pushed the feat/bound_querier_improve branch from c4f7bd9 to ef5cbb8 Compare March 5, 2024 13:51
@kulikthebird kulikthebird force-pushed the feat/remove_contract_module_support branch from 927ce26 to 1e19891 Compare March 5, 2024 21:07
@kulikthebird kulikthebird force-pushed the feat/bound_querier_improve branch 2 times, most recently from 6f41fcb to a9f7128 Compare March 5, 2024 21:17
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I very much like this change. Hope we will find out a way to skip Error = () in production code.

@kulikthebird kulikthebird self-assigned this Mar 11, 2024
@kulikthebird kulikthebird force-pushed the feat/remove_contract_module_support branch from 1e19891 to 0ab1392 Compare March 11, 2024 16:39
Base automatically changed from feat/remove_contract_module_support to main March 11, 2024 16:52
@kulikthebird kulikthebird force-pushed the feat/bound_querier_improve branch from a9f7128 to 6a4136d Compare March 11, 2024 16:57
@kulikthebird kulikthebird enabled auto-merge (squash) March 11, 2024 16:58
@kulikthebird kulikthebird merged commit 5970be8 into main Mar 11, 2024
11 checks passed
@kulikthebird kulikthebird deleted the feat/bound_querier_improve branch March 11, 2024 17:11
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants