Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

Add KamiD's validator key to genesis.json #9

Merged
merged 6 commits into from
Aug 6, 2020
Merged

Conversation

KamiD
Copy link
Contributor

@KamiD KamiD commented Aug 5, 2020

No description provided.

}
],
"public_key": null,
"account_number": "0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look right. We already have 0 above. But I am not an expert in genesis files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Account numbers start at 1. If I understand properly, new accounts always have 0 which mean "assign new auto-increment number". If you do a genesis export/import, you will have plenty of non-zero account_number and sequence number.

This is just how cosmos works, not a bug.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I am using command coral add-genesis-account to add my address, the account_number always be "0"

@KamiD KamiD requested a review from webmaster128 August 5, 2020 10:26
@ethanfrey
Copy link
Member

git checkout v0.10.0
make build-coral
./build/coral keys add debug-coral
./build/coral keys show debug-coral

this gives me:

- name: debug-coral
  type: local
  address: coral1fkszmlsrgaqvy9mmdywysz7mxp7pdcqcf54agy
  pubkey: coralpub1addwnpepqgy7frekuxjkl63t6slrxhk5v80yhp4wnu8dqp6wxwuyk6kl4agvgg7hur8
  mnemonic: ""
  threshold: 0
  pubkeys: []

@ethanfrey
Copy link
Member

@KamiD can you try the above commands and let me know what you get (using debug-coral).

If you still have issues with the prefixes, can you send me the output of uname -a and go version?

@KamiD
Copy link
Contributor Author

KamiD commented Aug 6, 2020

I have cleanup my build dir, rebuild it by make build-coral
using your cmd, those issue still happened:

- name: debug-coral
  type: local
  address: cosmos15utc8kqe9dr4ja3m7j8jpk450t560ara2yls5w
  pubkey: coralpub1addwnpepqvusm6nwcn9g68407s37edkcg6cqvcmdryl5ea5l0uwm0s2cw5n4vmj98at
  mnemonic: ""
  threshold: 0
  pubkeys: []

my uanme and go version is:

$ uname -a
Linux ip-172-31-19-41 5.3.0-1023-aws #25~18.04.1-Ubuntu SMP Fri Jun 5 15:18:30 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
$ go version
go version go1.13.4 linux/amd64

@KamiD
Copy link
Contributor Author

KamiD commented Aug 6, 2020

After I upgrading my go version to v1.14 and rebuild coral, the address is correct now~

@ethanfrey
Copy link
Member

Nice @KamiD thank you for taking the time to debug.

Can you git reset --hard origin/master and then run the coral add-account command again to generate the proper address in the genesis file?

Once this is updated, I am happy to merge.

@orkunkl
Copy link
Contributor

orkunkl commented Aug 6, 2020

@KamiD thank you for finding out the bug!

@orkunkl orkunkl merged commit 4d017fb into CosmWasm:master Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants