-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SilenceUsage flag to hide menu when an error occurs. #1068
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1068 +/- ##
==========================================
- Coverage 59.28% 59.16% -0.12%
==========================================
Files 53 53
Lines 6722 6735 +13
==========================================
Hits 3985 3985
- Misses 2442 2455 +13
Partials 295 295
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
The changes look good but a lot of commands were touched. I was wondering if it is sufficient to set SilenceUsage: true
on the GetTxCmd()
only. WDYT?
I agree that a more general soluton would be better. Unfortunately, I have tried your suggestion as first option but it didn't work. I had to add it to every command. |
👍 Good work |
* Add SilenceUsage flag to hide menu when an error occurs. * Fix lint errors
* Add SilenceUsage flag to hide menu when an error occurs. * Fix lint errors
* Add SilenceUsage flag to hide menu when an error occurs. * Fix lint errors
Resolves #973