Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable key name usage for admin #1103

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Enable key name usage for admin #1103

merged 1 commit into from
Dec 6, 2022

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Nov 21, 2022

Resolves #1039

@pinosu pinosu requested a review from alpe as a code owner November 21, 2022 11:46
@codecov
Copy link

codecov bot commented Nov 21, 2022 •
edited
Loading

Codecov Report

Merging #1103 (b3972f4) into main (fc476aa) will decrease coverage by 0.03%.
The diff coverage is 35.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
- Coverage   59.79%   59.76%   -0.04%     
==========================================
  Files          54       54              
  Lines        7273     7294      +21     
==========================================
+ Hits         4349     4359      +10     
- Misses       2612     2622      +10     
- Partials      312      313       +1
Impacted Files Coverage Δ
x/wasm/client/cli/gov_tx.go 6.82% <0.00%> (-0.14%) ⬇️
x/wasm/client/cli/tx.go 24.35% <57.14%> (+1.41%) ⬆️
x/wasm/client/cli/genesis_msg.go 71.04% <60.00%> (-0.39%) ⬇️
x/wasm/keeper/keeper.go 87.71% <0.00%> (+0.31%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

alpe
alpe approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌷

@pinosu pinosu merged commit 299d422 into main Dec 6, 2022
@webmaster128
Copy link
Member

❤️

@alpe alpe deleted the 1039-enable_key_name_admin branch May 10, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe alpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: Allow using key name for --admin
3 participants
@pinosu @webmaster128 @alpe