Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Close test dbs #1113

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Testing: Close test dbs #1113

merged 1 commit into from
Dec 5, 2022

Conversation

webmaster128
Copy link
Member

This issue came up in #1111. Thanks for the fix. I pulled this out here since we want to have it merged no matter if and when Windows support gets finalized.

@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #1113 (52ecb85) into main (a589fe9) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
- Coverage   59.95%   59.90%   -0.05%     
==========================================
  Files          54       54              
  Lines        7406     7408       +2     
==========================================
- Hits         4440     4438       -2     
- Misses       2641     2644       +3     
- Partials      325      326       +1     
Impacted Files Coverage Δ
app/test_helpers.go 0.78% <0.00%> (-0.01%) ⬇️
x/wasm/keeper/keeper.go 87.40% <0.00%> (-0.32%) ⬇️

@alpe alpe merged commit c5a7e5e into main Dec 5, 2022
@alpe alpe deleted the close-test-dbs branch May 10, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants