Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UpdateInstantiateConfig command #1121

Merged
merged 5 commits into from
Dec 20, 2022
Merged

Add UpdateInstantiateConfig command #1121

merged 5 commits into from
Dec 20, 2022

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Dec 12, 2022 •
edited
Loading

Resolves #843

@codecov
Copy link

codecov bot commented Dec 12, 2022 •
edited
Loading

Codecov Report

Merging #1121 (453b63b) into main (f3ebd92) will decrease coverage by 0.28%.
The diff coverage is 19.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1121      +/-   ##
==========================================
- Coverage   57.51%   57.22%   -0.29%     
==========================================
  Files          53       53              
  Lines        7289     7350      +61     
==========================================
+ Hits         4192     4206      +14     
- Misses       2801     2849      +48     
+ Partials      296      295       -1
Impacted Files Coverage Δ
x/wasm/client/cli/new_tx.go 0.00% <0.00%> (ø)
x/wasm/handler.go 63.63% <0.00%> (-3.04%) ⬇️
x/wasm/keeper/msg_server.go 27.09% <0.00%> (-1.29%) ⬇️
x/wasm/types/tx.go 48.21% <47.61%> (-0.07%) ⬇️
x/wasm/types/codec.go 100.00% <100.00%> (ø)
x/wasm/keeper/keeper.go 87.71% <0.00%> (+0.31%) ⬆️

@pinosu pinosu marked this pull request as ready for review December 13, 2022 08:13
@pinosu pinosu requested a review from alpe as a code owner December 13, 2022 08:13
alpe
alpe reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great already. Please add the new message type to the codec.go. Otherwise it can not be used.

x/wasm/keeper/msg_server.go Show resolved Hide resolved
x/wasm/types/tx.go Show resolved Hide resolved
x/wasm/types/tx.go Show resolved Hide resolved
x/wasm/types/tx.go Show resolved Hide resolved
proto/cosmwasm/wasm/v1/tx.proto Outdated
message MsgUpdateInstantiateConfig {
// Sender is the that actor that signed the messages
string sender = 1;
// CodeID references the new WASM code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
// CodeID references the new WASM code
// CodeID references the stored WASM code

x/wasm/client/cli/new_tx.go Show resolved Hide resolved
@pinosu pinosu force-pushed the 843-update_instantiate_config branch from 0567f4a to 453b63b Compare December 16, 2022 08:58
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
21.6% 21.6% Duplication

alpe
alpe approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Good work!🌷

x/wasm/types/tx_test.go
require.NoError(t, err)
})
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good test

@pinosu pinosu merged commit 14c2daa into main Dec 20, 2022
@pinosu pinosu deleted the 843-update_instantiate_config branch December 20, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe alpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update instantiate config command
2 participants
@pinosu @alpe