Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address cli behaviour on tx and query errors #1125

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Address cli behaviour on tx and query errors #1125

merged 3 commits into from
Jan 10, 2023

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Dec 13, 2022 •
edited
Loading

Closes #926

  • Removed old script

@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pinosu pinosu marked this pull request as ready for review December 22, 2022 11:47
@pinosu pinosu requested a review from alpe as a code owner December 22, 2022 11:47
@codecov
Copy link

codecov bot commented Dec 22, 2022 •
edited
Loading

Codecov Report

Merging #1125 (5daba10) into main (f3ebd92) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
+ Coverage   57.51%   57.53%   +0.02%     
==========================================
  Files          53       53              
  Lines        7289     7289              
==========================================
+ Hits         4192     4194       +2     
+ Misses       2801     2800       -1     
+ Partials      296      295       -1
Impacted Files Coverage Δ
x/wasm/client/cli/query.go 0.00% <ø> (ø)
x/wasm/keeper/keeper.go 87.71% <0.00%> (+0.31%) ⬆️

alpe
alpe approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@pinosu pinosu merged commit 558147d into main Jan 10, 2023
@pinosu pinosu deleted the 926-silence_usage branch January 10, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe alpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is the difference in codespace of error between execute and query intended behavior?
2 participants
@pinosu @alpe