Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove intertx for vanilla ICA #1159

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Remove intertx for vanilla ICA #1159

merged 1 commit into from
Jan 23, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jan 17, 2023 •
edited
Loading

Integrate Interchain Accounts from ibc-go module

  • contains sdk version bump
  • removes intertx module

@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alpe alpe marked this pull request as ready for review January 17, 2023 12:03
@codecov
Copy link

codecov bot commented Jan 17, 2023 •
edited
Loading

Codecov Report

Merging #1159 (ba499ae) into develop_sdk47 (e9a80cf) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           develop_sdk47    #1159      +/-   ##
=================================================
+ Coverage          58.98%   59.01%   +0.03%     
=================================================
  Files                 52       52              
  Lines               7158     7159       +1     
=================================================
+ Hits                4222     4225       +3     
+ Misses              2645     2644       -1     
+ Partials             291      290       -1
Impacted Files Coverage Δ
app/app.go 86.61% <100.00%> (+0.02%) ⬆️
x/wasm/keeper/keeper.go 87.40% <0.00%> (+0.31%) ⬆️

@alpe alpe mentioned this pull request Jan 19, 2023
Merged
pinosu
pinosu approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit 42dc194 into develop_sdk47 Jan 23, 2023
@alpe alpe deleted the ica_noauth branch January 23, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @pinosu