Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list-contract-by-code bugfix #1201

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

nik-suri
Copy link
Contributor

Adds Pagination Flags to the list-contract-by-code wasm query command.

Without the pagination flags, the query panics with

panic: flag accessed but not defined: page-key

@nik-suri nik-suri requested a review from alpe as a code owner February 13, 2023 19:53
@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
19.5% 19.5% Duplication

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #1201 (2ccffed) into main (88e01a9) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1201      +/-   ##
==========================================
- Coverage   57.49%   57.49%   -0.01%     
==========================================
  Files          54       54              
  Lines        7435     7436       +1     
==========================================
  Hits         4275     4275              
- Misses       2861     2862       +1     
  Partials      299      299              
Impacted Files Coverage Δ
x/wasm/client/cli/query.go 0.00% <0.00%> (ø)

@alpe
Copy link
Contributor

alpe commented Feb 16, 2023

Thank you! See #1198

This was referenced Feb 25, 2023
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you 🌷

@alpe alpe merged commit 40b4e6e into CosmWasm:main Mar 2, 2023
alpe added a commit that referenced this pull request Mar 2, 2023
@nik-suri nik-suri deleted the list-contract-code-bugfix branch March 2, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants