sdk 47 working branch #1202
Closed
sdk 47 working branch #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Link: #1198 |
|
Notional hasn't done like: |
|
Maybe I am missing something, but would it not be a good idea to take adding a new CI system in a separate PR? This PR is already huge. If there is an agreement to go from circleci to gh actions (which makes sense to me, personally) this could perhaps get through fairly quickly to main without having to wait for this particular branch. |
|
@gjermundgaraba the ci changes were made to improve the repo's portability and forkability |
|
Closed in favor of #1149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another placeholder draft PR for Notional's work to support sdk v0.47.x.
Please consider it to be dangerously incomplete at this time. Don't use it in prod, please and thank you <3