Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test rust panic for regression #1236

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Test rust panic for regression #1236

merged 1 commit into from
Mar 6, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Mar 6, 2023

Regression test for panic in Rust

@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #1236 (a52e604) into main (3160256) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
- Coverage   57.47%   57.44%   -0.03%     
==========================================
  Files          54       54              
  Lines        7443     7443              
==========================================
- Hits         4278     4276       -2     
- Misses       2864     2865       +1     
- Partials      301      302       +1     
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 87.50% <0.00%> (-0.32%) ⬇️

@@ -542,6 +542,29 @@ func TestWasmRawQueryWithNil(t *testing.T) {
require.Equal(t, []byte{}, reflectRawRes.Data)
}

func TestRustPanicIsHandled(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests!

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit cb17a41 into main Mar 6, 2023
@alpe alpe deleted the rust_panic branch March 6, 2023 13:10
alpe added a commit that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants