Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linters #1240

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Fix linters #1240

merged 1 commit into from
Mar 7, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Mar 6, 2023

Address linter issues

@alpe alpe changed the base branch from main to develop_sdk47 March 6, 2023 15:24
@alpe alpe requested a review from pinosu March 6, 2023 15:24
@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
4.5% 4.5% Duplication

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #1240 (ccf3a88) into develop_sdk47 (7969723) will decrease coverage by 0.02%.
The diff coverage is 56.54%.

Impacted file tree graph

@@                Coverage Diff                @@
##           develop_sdk47    #1240      +/-   ##
=================================================
- Coverage          59.39%   59.37%   -0.02%     
=================================================
  Files                 53       53              
  Lines               7253     7255       +2     
=================================================
  Hits                4308     4308              
- Misses              2645     2646       +1     
- Partials             300      301       +1     
Impacted Files Coverage Δ
app/ante.go 64.28% <0.00%> (ø)
x/wasm/client/cli/new_tx.go 0.00% <0.00%> (ø)
x/wasm/ibc.go 67.23% <0.00%> (ø)
x/wasm/keeper/msg_server.go 26.25% <0.00%> (ø)
x/wasm/keeper/snapshotter.go 65.07% <0.00%> (ø)
x/wasm/keeper/query_plugins.go 82.60% <11.76%> (ø)
x/wasm/keeper/proposal_handler.go 64.00% <14.28%> (ø)
x/wasm/keeper/querier.go 72.07% <25.00%> (ø)
x/wasm/keeper/handler_plugin_encoders.go 80.30% <28.57%> (ø)
x/wasm/keeper/handler_plugin.go 81.72% <45.45%> (-1.80%) ⬇️
... and 15 more

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit 52d6b1f into develop_sdk47 Mar 7, 2023
@alpe alpe deleted the fix_linters branch March 7, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants