Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint main branch #1272

Closed
wants to merge 19 commits into from
Closed

lint main branch #1272

wants to merge 19 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 17, 2023

This PR lints the main branch more strictly.

  • revive has all options turned on
  • linting fixes from develop_47 have been improved upon

@faddat faddat changed the title lint main branch, autofixes lint main branch Mar 17, 2023
@faddat faddat marked this pull request as ready for review March 19, 2023 11:41
@faddat faddat requested a review from alpe as a code owner March 19, 2023 11:41
@mergify mergify bot mentioned this pull request Mar 19, 2023
@alpe
Copy link
Contributor

alpe commented Mar 20, 2023

Thanks but why would we need this with #1149 merged to main today? I would expect this to create conflicts only.

@faddat
Copy link
Contributor Author

faddat commented Mar 20, 2023

mainly thinking about past versions. I also made a conflict cleaning PR, #1274

@faddat
Copy link
Contributor Author

faddat commented Mar 20, 2023

Didn't wanna bring ya merge conflicts. Actually, when we are both done shipping like wild, I'd really like to talk with you about branching in this repo.

feel free to close this if you prefer.

@alpe
Copy link
Contributor

alpe commented Mar 20, 2023

When #1149 is merged to main, all development will continue on main again. There will be a maintenance branch for security fixes on the sdk45 series for some time but no backport of features planned.
The branch will be called releases/v0.3x. The first version with 47 support will be v0.40.0

@alpe alpe closed this Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants