Add amino annotations to proto #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have successfully added a new CodeQL configuration |
|
@Mergifyio rebase |
Codecov Report
@@ Coverage Diff @@
## main #1280 +/- ##
==========================================
+ Coverage 63.44% 63.47% +0.02%
==========================================
Files 56 56
Lines 6971 6971
==========================================
+ Hits 4423 4425 +2
+ Misses 2219 2218 -1
+ Partials 329 328 -1
|
|
LGTM! |
pyramation
approved these changes
Mar 30, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 11, 2023
* Add amino annotations to proto * Formatting only (cherry picked from commit 887ee0e) # Conflicts: # app/app.go # proto/cosmwasm/wasm/v1/proposal.proto # proto/cosmwasm/wasm/v1/tx.proto # x/wasm/keeper/msg_server_integration_test.go # x/wasm/types/proposal.pb.go # x/wasm/types/query.pb.go # x/wasm/types/tx.pb.go # x/wasm/types/types.pb.go
|
No backport as amino.proto was introduced > sdk 45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1157
@pyramation please review: the failing tests/ linter/ simulations runs can be ignored as this stage. I am going to rebase the branch later. I am more interested if this PR includes all the annotations that you need