Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweak and test files #1356

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Apr 21, 2023

  • Moves "default" authority address to global var so that it can be overwritten by chain architects
  • Add manual test script to submit a wasm proposal

@@ -0,0 +1,19 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good example 👍

@@ -25,6 +25,10 @@ import (
"github.com/CosmWasm/wasmd/x/wasm/types"
)

// DefaultGovAuthority is set to the gov module address.
// Extension point for chains to overwrite the default
var DefaultGovAuthority = sdk.AccAddress(address.Module("gov"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have this! Also the code looks cleaner.

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit f10ca89 into 1301-support_proposals Apr 21, 2023
@alpe alpe deleted the 1301-support_proposals_updates branch April 21, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants