Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply review feedback (backport #1376) #1384

Merged
merged 2 commits into from
May 10, 2023
Merged

Apply review feedback (backport #1376) #1384

merged 2 commits into from
May 10, 2023

Commits on May 10, 2023

  1. Apply review feedback (#1376) 

    * Apply review feedback

* Better test name

* Add contract integration test

* Better doc in test and minor refactoring

(cherry picked from commit 29481db)
    @alpe @mergify
    alpe authored and mergify[bot] committed May 10, 2023
    Configuration menu
    Copy the full SHA
    656386f View commit details
    Browse the repository at this point in the history

  2. Set correct test chain id

    @alpe
    alpe committed May 10, 2023
    Configuration menu
    Copy the full SHA
    d001353 View commit details
    Browse the repository at this point in the history