Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alpine to build wasmd docker image #139

Merged
merged 7 commits into from
Jun 15, 2020
Merged

Use alpine to build wasmd docker image #139

merged 7 commits into from
Jun 15, 2020

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Jun 10, 2020

Depends on CosmWasm/wasmvm#106

Uses a alpine compiler docker image (from go-cosmwasm) to build a static lib from go-cosmwasm, the compile it to a static go binary. After this is completed, copy the wasmd and wasmcli binaries into a minimal alpine image along with the helper scripts we use in CI (cosmjs) testing.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added relevant godoc comments.

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the Github PR explorer


For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ethanfrey ethanfrey marked this pull request as ready for review June 15, 2020 22:37
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   61.99%   61.99%           
=======================================
  Files          20       20           
  Lines        1768     1768           
=======================================
  Hits         1096     1096           
  Misses        578      578           
  Partials       94       94           
Impacted Files Coverage Δ
x/wasm/internal/keeper/keeper.go 86.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5fdbb...a0c1c52. Read the comment docs.

@ethanfrey ethanfrey merged commit 50ffd80 into master Jun 15, 2020
@ethanfrey ethanfrey deleted the alpine-docker branch June 15, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants