Research: wazerod #1475
Research: wazerod #1475
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for k, v := range balances { | ||
| dst := make([]types.Coin, len(v)) | ||
| copy(dst, v) | ||
| bal[k] = dst | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
|
|
||
| import ( | ||
| "fmt" | ||
| "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import
| go func() { | ||
| if useMtx { | ||
| defer db.mtx.RUnlock() | ||
| } | ||
| // Because we use [start, end) for reverse ranges, while btree uses (start, end], we need | ||
| // the following variables to handle some reverse iteration conditions ourselves. | ||
| var ( | ||
| skipEqual []byte | ||
| abortLessThan []byte | ||
| ) | ||
| visitor := func(i btree.Item) bool { | ||
| item := i.(*item) | ||
| if skipEqual != nil && bytes.Equal(item.key, skipEqual) { | ||
| skipEqual = nil | ||
| return true | ||
| } | ||
| if abortLessThan != nil && bytes.Compare(item.key, abortLessThan) == -1 { | ||
| return false | ||
| } | ||
| select { | ||
| case <-ctx.Done(): | ||
| return false | ||
| case ch <- item: | ||
| return true | ||
| } | ||
| } | ||
| switch { | ||
| case start == nil && end == nil && !reverse: | ||
| db.btree.Ascend(visitor) | ||
| case start == nil && end == nil && reverse: | ||
| db.btree.Descend(visitor) | ||
| case end == nil && !reverse: | ||
| // must handle this specially, since nil is considered less than anything else | ||
| db.btree.AscendGreaterOrEqual(newKey(start), visitor) | ||
| case !reverse: | ||
| db.btree.AscendRange(newKey(start), newKey(end), visitor) | ||
| case end == nil: | ||
| // abort after start, since we use [start, end) while btree uses (start, end] | ||
| abortLessThan = start | ||
| db.btree.Descend(visitor) | ||
| default: | ||
| // skip end and abort after start, since we use [start, end) while btree uses (start, end] | ||
| skipEqual = end | ||
| abortLessThan = start | ||
| db.btree.DescendLessOrEqual(newKey(end), visitor) | ||
| } | ||
| close(ch) | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine
* remove no cgo tests * repository cleanup * add test and lint * cleanup * wazero-fixes * all tests pass again * finish linting * remove the "builders" folder, it will no longer be needed * lint docs * Revert "remove the "builders" folder, it will no longer be needed" This reverts commit d5d696c. * format INTEGRATION.md * bump rust package versions * keep circleci since we are submitting this upstream for advice / review /ideas * only run github actions on 1.20 * update ci
|
Thanks for sharing. Please note that we have very limited capacity and focusing on the sdk 50 upgrade and mesh security. |
|
@alpe makes perfect sense, this would certainly be a spike. |
|
@faddat can we close this now? |
|
Hey @webmaster128 Thanks for keeping this here as long as you did. I do indeed think it is quite safe to close now. Makes more sense to check out wasmvm 2.0 instead of reinventing the wheel.... |
Hey I wanted to share with confio and the larger CW community, some research that I have been attempting.
You probably don't want to review this for merge, it's really not ready for that yet.
However, you might, if you find the concept interesting, want to review it.
This template branch is a beginning of an attempt to eliminate dependencies on CGO in WASMD & wasmvm.
As a side effect, it would eliminate the wasmvm repository.
You will also find notes interspersed throughout the code, on places where I think that CGO is harmful.
I'm working on this in a couple of branches, and I'm about to make a merge of one of them to the branch that represents this PR, and you can find more information on the research here:
https://hackmd.io/@xklVAbyuQ9m2DFWqzADekw/B19vvqhuh
current state
Right now this has combined wasmvm and WASMD, and has not yet implemented wazero.
There are a number of open questions that have been outlined in the hackmd above.
foundation of thought