Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/Remove addresses for code upload params #1493

Merged
merged 5 commits into from
Jul 19, 2023
Merged

Add/Remove addresses for code upload params #1493

merged 5 commits into from
Jul 19, 2023

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Jul 7, 2023

Resolves #1491

@codecov
Copy link

codecov bot commented Jul 7, 2023 •
edited
Loading

Codecov Report

Merging #1493 (9276699) into main (c23ecae) will decrease coverage by 0.27%.
The diff coverage is 42.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
- Coverage   58.15%   57.89%   -0.27%     
==========================================
  Files          64       64              
  Lines        8460     8602     +142     
==========================================
+ Hits         4920     4980      +60     
- Misses       3131     3209      +78     
- Partials      409      413       +4
Impacted Files Coverage Δ
x/wasm/client/cli/gov_tx.go 13.05% <0.00%> (-1.32%) ⬇️
x/wasm/keeper/query_plugins.go 84.14% <ø> (ø)
x/wasm/types/tx.go 47.26% <48.83%> (+0.20%) ⬆️
x/wasm/keeper/msg_server.go 64.80% <81.39%> (+3.44%) ⬆️
x/wasm/types/codec.go 100.00% <100.00%> (ø)

@pinosu pinosu marked this pull request as ready for review July 10, 2023 11:15
@pinosu pinosu requested a review from alpe as a code owner July 10, 2023 11:15
@pinosu pinosu changed the title [WIP] Add/Remove addresses for code upload params Add/Remove addresses for code upload params Jul 10, 2023
alpe
alpe reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Some minor comments on the code.
I have not 👁️ at the tests yet.

x/wasm/client/cli/gov_tx.go Show resolved Hide resolved
x/wasm/keeper/msg_server.go Show resolved Hide resolved
x/wasm/keeper/msg_server.go Outdated Show resolved Hide resolved
x/wasm/keeper/msg_server.go Outdated Show resolved Hide resolved
x/wasm/types/tx.go Outdated Show resolved Hide resolved
x/wasm/types/tx.go Outdated Show resolved Hide resolved
x/wasm/types/tx.go Outdated Show resolved Hide resolved
pinosu and others added 2 commits July 19, 2023 10:36
@pinosu
Fix comments
6ec3600
@alpe
Minor chore (#1522)
9276699 
* Minor chore

* Remove duplicate tests
alpe
alpe approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 💯

@alpe alpe merged commit 19c17cb into main Jul 19, 2023
@alpe alpe deleted the 1491-add_remove_anyofaddr_proposal branch July 19, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe alpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AnyOfAddresses list Append/Remove
2 participants
@pinosu @alpe