Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build release + artifact on CI #1515

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Build release + artifact on CI #1515

merged 1 commit into from
Jul 18, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jul 18, 2023 •
edited
Loading

Store artifact on release.
Step 1 for #1480

CircleCI is setup with GITHUB_CREDS to evaluate this for 90days

@alpe alpe requested a review from pinosu July 18, 2023 10:33
pinosu
pinosu approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! LGTM 👍

@alpe alpe merged commit 6d770a5 into main Jul 18, 2023
6 checks passed
@alpe alpe deleted the release_artifacts branch July 18, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @pinosu