Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove "check" from make test-all #1548

Merged
merged 1 commit into from
Aug 4, 2023
Merged

remove "check" from make test-all #1548

merged 1 commit into from
Aug 4, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 4, 2023

this PR fixes make test-all by removing the check job from it.

@faddat faddat requested a review from alpe as a code owner August 4, 2023 12:50
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1548 (71f804b) into main (dc970c4) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1548      +/-   ##
==========================================
- Coverage   58.03%   58.00%   -0.03%     
==========================================
  Files          64       64              
  Lines        8640     8640              
==========================================
- Hits         5014     5012       -2     
- Misses       3214     3215       +1     
- Partials      412      413       +1

see 1 file with indirect coverage changes

pinosu
pinosu approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! LGTM 👍

@pinosu pinosu merged commit a2373f0 into CosmWasm:main Aug 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

@alpe alpe Awaiting requested review from alpe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faddat @pinosu