Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gas calculation #1567

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Fix gas calculation #1567

merged 1 commit into from
Aug 24, 2023

Conversation

chipshort
Copy link
Collaborator

@chipshort chipshort commented Aug 22, 2023 •
edited
Loading

closes #1536

@chipshort chipshort requested a review from alpe as a code owner August 22, 2023 10:14
@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Merging #1567 (d0e3ed1) into main (3de2c49) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1567      +/-   ##
==========================================
+ Coverage   58.00%   58.03%   +0.02%     
==========================================
  Files          64       64              
  Lines        8640     8640              
==========================================
+ Hits         5012     5014       +2     
+ Misses       3215     3214       -1     
+ Partials      413      412       -1
Files Changed Coverage Δ
x/wasm/keeper/query_plugins.go 83.78% <100.00%> (ø)

... and 1 file with indirect coverage changes

@webmaster128 webmaster128 mentioned this pull request Aug 22, 2023
Closed
webmaster128
webmaster128 reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is most likely consensus breaking (or you can at least create cases in which it is), so I'd not put that in a patch release.

@pinosu pinosu changed the title Fix #1536 Fix gas calculation Aug 22, 2023
@pinosu pinosu added the backport/v0.3x Backport patches to sdk45 release branch label Aug 22, 2023
pinosu
pinosu approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this task! LGTM 💯

@faddat faddat mentioned this pull request Aug 22, 2023
Closed
@pinosu pinosu merged commit bfaf589 into CosmWasm:main Aug 24, 2023
8 checks passed
mergify bot pushed a commit that referenced this pull request Aug 24, 2023
@chipshort @mergify
Fix gas calculation (#1567)
875ad3e 
(cherry picked from commit bfaf589)
@mergify mergify bot mentioned this pull request Aug 24, 2023
Merged
pinosu pushed a commit that referenced this pull request Aug 24, 2023
@mergify @chipshort
Fix gas calculation (#1567) (#1570)
390fda7 
(cherry picked from commit bfaf589)

Co-authored-by: Christoph Otter <chris@confio.gmbh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 left review comments

@pinosu pinosu pinosu approved these changes

@alpe alpe Awaiting requested review from alpe

Assignees
No one assigned
Labels
backport/v0.3x Backport patches to sdk45 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] The wasmd querier GasConsumed() is not adaptive wasmvm, maybe cause an attack。
3 participants
@chipshort @webmaster128 @pinosu