-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy gov proposal dependencies #1587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just make sure that you do not fully remove the legacy router. It may still be needed by some modules/ in flight proposals
Codecov Report
@@ Coverage Diff @@
## main #1587 +/- ##
==========================================
- Coverage 58.26% 56.59% -1.67%
==========================================
Files 64 64
Lines 8767 8755 -12
==========================================
- Hits 5108 4955 -153
- Misses 3243 3414 +171
+ Partials 416 386 -30
|
9915aa1
to
0040a64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good now! Thanks for taking care!
The README contains a section about runtime flags that should be updated, too. Please remove the gov example there.
@alpe thanks for the review. I think I have removed everything from the README already. |
It makes sense to have the other docs updated, too. 👍 |
61ef629
to
3bca949
Compare
Resolves #1583