Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy gov proposal dependencies #1587

Merged
merged 6 commits into from
Sep 7, 2023

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Aug 30, 2023

Resolves #1583

@pinosu pinosu requested a review from alpe as a code owner August 30, 2023 14:21
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just make sure that you do not fully remove the legacy router. It may still be needed by some modules/ in flight proposals

app/app.go Outdated Show resolved Hide resolved
x/wasm/keeper/test_common.go Show resolved Hide resolved
x/wasm/keeper/proposal_integration_test.go Show resolved Hide resolved
README.md Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #1587 (7ef438b) into main (0f82c95) will decrease coverage by 1.67%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1587      +/-   ##
==========================================
- Coverage   58.26%   56.59%   -1.67%     
==========================================
  Files          64       64              
  Lines        8767     8755      -12     
==========================================
- Hits         5108     4955     -153     
- Misses       3243     3414     +171     
+ Partials      416      386      -30     
Files Changed Coverage Δ
app/app.go 86.38% <ø> (+0.07%) ⬆️
app/test_helpers.go 62.44% <50.00%> (ø)

... and 3 files with indirect coverage changes

@pinosu pinosu force-pushed the 1583-remove_legacy_proposal_deps branch from 9915aa1 to 0040a64 Compare September 5, 2023 08:56
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good now! Thanks for taking care!
The README contains a section about runtime flags that should be updated, too. Please remove the gov example there.

@alpe alpe added this to the v0.42.0 milestone Sep 6, 2023
@pinosu
Copy link
Contributor Author

pinosu commented Sep 6, 2023

@alpe thanks for the review. I think I have removed everything from the README already.
I only found the one example in Vote on the upgrade and some more docs in Governance.md . Should I update also these?

@alpe
Copy link
Contributor

alpe commented Sep 7, 2023

I only found the one example in Vote on the upgrade and some more docs in Governance.md . Should I update also these?

It makes sense to have the other docs updated, too. 👍

@alpe alpe removed this from the v0.42.0 milestone Sep 7, 2023
@pinosu pinosu force-pushed the 1583-remove_legacy_proposal_deps branch from 61ef629 to 3bca949 Compare September 7, 2023 12:18
@pinosu pinosu merged commit 09b5008 into main Sep 7, 2023
6 of 8 checks passed
@pinosu pinosu deleted the 1583-remove_legacy_proposal_deps branch September 7, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove v1beta1 gov proposals integration
2 participants