Add logging for query err before redacting #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1605 +/- ##
=======================================
Coverage 58.22% 58.23%
=======================================
Files 64 64
Lines 8642 8643 +1
=======================================
+ Hits 5032 5033 +1
Misses 3197 3197
Partials 413 413
|
alpe
approved these changes
Sep 6, 2023
x/wasm/keeper/query_plugins.go
Outdated
| @@ -71,6 +71,7 @@ func (q QueryHandler) Query(request wasmvmtypes.QueryRequest, gasLimit uint64) ( | |||
| } | |||
|
|
|||
| // Issue #759 - we don't return error string for worries of non-determinism | |||
| moduleLogger(q.Ctx).Info("Redacting submessage error", "cause", err) | |||
There was a problem hiding this comment.
This solves the issue but let's use debug level to not confuse with extra output
alpe
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Add logging for query err before redacting * Fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1593