Restrict pagination on all-state-query #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1619 +/- ##
==========================================
+ Coverage 56.59% 56.62% +0.02%
==========================================
Files 64 64
Lines 8755 8760 +5
==========================================
+ Hits 4955 4960 +5
- Misses 3414 3415 +1
+ Partials 386 385 -1
|
pinosu
reviewed
Sep 13, 2023
| @@ -368,7 +368,10 @@ func GetCmdGetContractStateAll() *cobra.Command { | |||
| SilenceUsage: true, | |||
| } | |||
| flags.AddQueryFlagsToCmd(cmd) | |||
| flags.AddPaginationFlagsToCmd(cmd, "contract state") | |||
| cmd.Flags().String(flags.FlagPageKey, "", "pagination page-key of contract state to query for") | |||
| cmd.Flags().Uint64(flags.FlagLimit, 100, "pagination limit of contract state to query for") | |||
pinosu
reviewed
Sep 13, 2023
| }, | ||
| "with pagination count": { | ||
| srcQuery: &types.QueryAllContractStateRequest{ | ||
| Address: contractAddr.String(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterating via key is the best performing option.