Fix genesis import with predictable addresses

[alpe]

Resolves #1629

[codecov]

Codecov Report

Merging #1630 (7dc2d0c) into main (7dba5c7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1630   +/-   ##
=======================================
  Coverage   56.66%   56.66%           
=======================================
  Files          64       64           
  Lines        8917     8917           
=======================================
  Hits         5053     5053           
  Misses       3475     3475           
  Partials      389      389           

Files Changed	Coverage Δ
x/wasm/keeper/genesis.go	88.40% <100.00%> (ø)

[pinosu]

LGTM 👍

[czarcas7ic]

This fix doesn't confirm that contracts with predictable addresses were properly exported though right?

[alpe]

This fix doesn't confirm that contracts with predictable addresses were properly exported though right?

All contracts are stored in the same model and exported. This fix ensures that predictable addresses do not cause issues on genesis import. The contract id sequence had a constraint for sanity that ensured contractID_Seq > count(contract). With any predictable address though the count(contract) is always > contractID_Seq. Therefore the fix is either
a) bump contractID_Seq for every contract instantiation
b) export count(contract) +1 as contractID_Seq
c) replace the import constraint with something better

My motivation for c)
a) comes with some extra storage IO and gas costs
b) creates a different state on export/import in the store and will cause tests to fail
c) the constraint this is only a safety net to fail fast on inconsistent manual editions to the genesis. We achieve the same by checking that the next contract address is available and not used