Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default query limit and ensure constraints #1632

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Set default query limit and ensure constraints #1632

merged 2 commits into from
Sep 18, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Sep 18, 2023

After another round of feedback, I applied more restrictive pagination checks. Thanks @tubackkhoa
This may affect CLI and other clients

@alpe alpe requested a review from pinosu September 18, 2023 08:24
pinosu
pinosu reviewed Sep 18, 2023
View reviewed changes
x/wasm/client/cli/query.go Outdated Show resolved Hide resolved
pinosu
pinosu approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited
Loading

Codecov Report

Merging #1632 (b9134e2) into main (7dba5c7) will increase coverage by 0.09%.
Report is 2 commits behind head on main.
The diff coverage is 77.77%.

❗ Current head b9134e2 differs from pull request most recent head 4239b27. Consider uploading reports for the commit 4239b27 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1632      +/-   ##
==========================================
+ Coverage   56.66%   56.75%   +0.09%     
==========================================
  Files          64       64              
  Lines        8917     8945      +28     
==========================================
+ Hits         5053     5077      +24     
- Misses       3475     3478       +3     
- Partials      389      390       +1
Files Changed Coverage Δ
x/wasm/client/cli/query.go 0.00% <0.00%> (ø)
x/wasm/keeper/querier.go 76.56% <100.00%> (+1.77%) ⬆️

@alpe @pinosu
Update x/wasm/client/cli/query.go
4239b27 
Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com>
@alpe alpe merged commit afa85da into main Sep 18, 2023
3 checks passed
@alpe alpe deleted the max_limit branch September 18, 2023 09:25
alpe added a commit that referenced this pull request Sep 19, 2023
@alpe
Merge branch 'main' into sdk-upgrade050_rebased3
902b901 
* main:
  Set default query limit and ensure constraints (#1632)
  Fix genesis import with predictable addresses
  Add grant system tests (#1626)
  Ensure some contraints and limits on pin/unpin code ids
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @pinosu