Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system tests for chain upgrade - backport #1644

Closed
wants to merge 16 commits into from
Closed

Add system tests for chain upgrade - backport #1644

wants to merge 16 commits into from

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Sep 29, 2023

Backport #1643

@alpe alpe requested a review from pinosu September 29, 2023 15:59
@alpe alpe marked this pull request as ready for review September 29, 2023 15:59
pinosu
pinosu approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🥇 LGTM 👍
There are still some todos in the test upgrade code.. not sure if they can be removed or you were planing to add more maybe in another pr.

@alpe alpe changed the title Add system tests for chain upgrade Add system tests for chain upgrade - backport Oct 4, 2023
pinosu
pinosu reviewed Oct 5, 2023
View reviewed changes
Makefile Show resolved Hide resolved
pinosu
pinosu reviewed Oct 5, 2023
View reviewed changes
tests/system/upgrade_test.go Outdated Show resolved Hide resolved
pinosu
pinosu approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 💯 LGTM 👍

@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #1644 (b537945) into releases/v0.4x (7270ccd) will increase coverage by 0.07%.
Report is 2 commits behind head on releases/v0.4x.
The diff coverage is 85.18%.

❗ Current head b537945 differs from pull request most recent head ad52bd9. Consider uploading reports for the commit ad52bd9 to get more accurate results

Impacted file tree graph

@@                Coverage Diff                 @@
##           releases/v0.4x    #1644      +/-   ##
==================================================
+ Coverage           57.58%   57.66%   +0.07%     
==================================================
  Files                  62       62              
  Lines                8078     8071       -7     
==================================================
+ Hits                 4652     4654       +2     
+ Misses               3040     3032       -8     
+ Partials              386      385       -1
Files Coverage Δ
app/upgrades.go 90.69% <85.18%> (+16.69%) ⬆️

pinosu
pinosu approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

tests/system/cli.go Outdated Show resolved Hide resolved
@alpe @pinosu
Update tests/system/cli.go
ad52bd9 
Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com>
@alpe
Copy link
Contributor Author

alpe commented Oct 18, 2023

The upgrade test is flacky on this branch. Not sure if we should invest more time into this. 🤷

@alpe alpe closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @pinosu