fix: propagate funds validation errors #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1649 +/- ##
=======================================
Coverage 56.59% 56.59%
=======================================
Files 62 62
Lines 8194 8194
=======================================
Hits 4637 4637
Misses 3120 3120
Partials 437 437
|
alpe
reviewed
Oct 4, 2023
The validation functions on the `tx` type masquerade the root error message for the `Funds` validation. Having the original error helps to save time when debugging the cause for a failed tx. One example is if someone sends multiple funds to a contract execution without sorting the denoms, which is one of the validations in the `Coins.Validate` method. With the error propagation, the developer can quickly determine why the tx failed.
aelesbao
force-pushed
the
aelesbao/fix/propagate-funds-err
branch
from
3a17028
to
6b8b45c
Compare
|
Thanks for the reply, @alpe. I've rebased the branch and updated the pull request description. |
alpe
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation functions on the
txtype masquerade the root error message for theFundsvalidation. Having the original error helps to save time when debugging the cause for a failed tx.One example is if someone sends multiple funds to a contract execution without sorting the denoms, which is one of the validations in the
Coins.Validatemethod. With the error propagation, the developer can quickly determine why the tx failed.