Add label validation for non printable chars (backport #1650) #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## releases/v0.4x #1659 +/- ##
==================================================
+ Coverage 57.58% 57.61% +0.03%
==================================================
Files 62 62
Lines 8078 8084 +6
==================================================
+ Hits 4652 4658 +6
Misses 3040 3040
Partials 386 386
|
alpe
approved these changes
Oct 9, 2023
|
This may break some contracts that misuse labels. I am not sure if this a good idea to ship it with the wasmvm bugfix. Maybe better postpone it to v0.44. WDYT? |
|
@Mergifyio rebase |
* Add label validation for non printable chars * Fix printable chars check (cherry picked from commit 1a22c29)
✅ Branch has been successfully rebased |
pinosu
force-pushed
the
mergify/bp/releases/v0.4x/pr-1650
branch
from
e68f5ea
to
a19ccba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1650 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com