use latest sdk #1681
Closed
use latest sdk #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1681 +/- ##
==========================================
- Coverage 56.80% 56.77% -0.03%
==========================================
Files 62 62
Lines 8232 8232
==========================================
- Hits 4676 4674 -2
- Misses 3119 3120 +1
- Partials 437 438 +1 |
Merged
alpe
reviewed
Nov 8, 2023
| @@ -104,7 +105,8 @@ func NewRootCmd() *cobra.Command { | |||
| // add keyring to autocli opts | |||
| autoCliOpts := tempApp.AutoCliOpts() | |||
| initClientCtx, _ = config.ReadFromClientConfig(initClientCtx) | |||
| autoCliOpts.Keyring = initClientCtx.Keyring | |||
| autoCliOpts.Keyring, _ = keyring.NewAutoCLIKeyring(initClientCtx.Keyring) | |||
Closed
|
Thanks for your work! Closing in favor of #1696 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small cmd folder change that will be useful when v50 launches.
@alpe -- this one contains the changes from #1680 that would be useful for the main branch.