-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix migrate legacy params #1729
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
- Coverage 57.25% 54.89% -2.37%
==========================================
Files 63 64 +1
Lines 8818 9640 +822
==========================================
+ Hits 5049 5292 +243
- Misses 3287 3822 +535
- Partials 482 526 +44
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Nice to see also the example for upgrades from 33 to 50. Very useful 💯
Definitely good to mention it in the CHANGELOG 👍
Resolves #1725
See # 1732