Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add sender specification for contracts sending tx #174

Closed
wants to merge 1 commit into from
Closed

WIP: Add sender specification for contracts sending tx #174

wants to merge 1 commit into from

Conversation

hskang9
Copy link

@hskang9 hskang9 commented Jul 4, 2020

Resolves #420 in cosmwasm

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • [ x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added relevant godoc comments.

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@hskang9 hskang9 requested a review from ethanfrey as a code owner July 4, 2020 16:38
@ethanfrey
Copy link
Member

As mentioned here this is a giant security hole, and we already ensure the contract dispatching the message is the proper sender.

@ethanfrey ethanfrey closed this Jul 6, 2020
alpe pushed a commit that referenced this pull request Jan 21, 2021
@ethanfrey
Wasmvm ibc final (#9)
1f5e57c 
* Update to tip of wasmvm PR #174

* Revert ContractFlags on Instantiate

This reverts commit d32ecc4.

* TimeoutHeight -> TimeoutBlock

* Update test contracts

* Use AnalyzeCode to get ibc flags

* Enable conditional ibc port binding on init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requirements for some built-in functions as VYPER(EVM)
2 participants
@hskang9 @ethanfrey