Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading error message for duplicate address on instantiate2 #1816

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

webmaster128
Copy link
Member

Chaning the label does not help avoiding the collision. Only creator, checksum and salt is typically used.

Chaning the label does not help avoiding the collision. Only creator,
checksum and salt is typically used.
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice comment 👍

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.01%. Comparing base (9e44af1) to head (8e184df).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1816   +/-   ##
=======================================
  Coverage   55.01%   55.01%           
=======================================
  Files          64       64           
  Lines        9663     9663           
=======================================
  Hits         5316     5316           
  Misses       3821     3821           
  Partials      526      526           
Files Coverage Δ
x/wasm/keeper/keeper.go 80.02% <100.00%> (ø)

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@webmaster128 webmaster128 added this to the v0.51 milestone Feb 29, 2024
@webmaster128 webmaster128 merged commit 96e2b91 into main Feb 29, 2024
16 checks passed
@webmaster128 webmaster128 deleted the fix-address-exists-error-message branch February 29, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants