Fix instantiate2 proposal cli command #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1934 +/- ##
==========================================
- Coverage 54.42% 54.31% -0.11%
==========================================
Files 65 65
Lines 9976 9995 +19
==========================================
Hits 5429 5429
- Misses 3992 4011 +19
Partials 555 555
|
| cmd := &cobra.Command{ | ||
| Use: "instantiate-contract-2 [code_id_int64] [json_encoded_init_args] --authority [address] --label [text] --title [text] --summary [text] --admin [address,optional] --amount [coins,optional]", | ||
| Use: "instantiate-contract-2 [code_id_int64] [json_encoded_init_args] [salt] --authority [address] --label [text] --title [text] " + |
There was a problem hiding this comment.
In build-address this is called [salt-hex-encoded]. Not sure if that is an elegant way to name those arguments but I think it's important for the user to know the encoding.
There was a problem hiding this comment.
But hex is only the default here. You can change the encoding using the --ascii, --b64 and --hex flags.
There was a problem hiding this comment.
Oh, I see. Then let's keep it as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.