Bump cosmos-sdk v0.53.0 #2250

pinosu · 2025-05-09T12:12:14Z

No description provided.

chipshort

Changes look alright to me so far, but what's happening with the CI?

kulikthebird · 2025-05-22T19:14:30Z

I have the same problem with benchmarks tests as CI on my machine. Btw. we need that for IBCv2 implementation on 0.55.x / 0.56.x - I guess we'd need to backport this.

codecov · 2025-05-23T15:41:48Z

Codecov Report

Attention: Patch coverage is 93.91304% with 7 lines in your changes missing coverage. Please review.

Project coverage is 46.00%. Comparing base (3565576) to head (7a94243).
Report is 1 commits behind head on releases/v0.6x.

Files with missing lines	Patch %	Lines
app/upgrades/v060/upgrades.go	0.00%	3 Missing ⚠️
app/app.go	98.16%	2 Missing ⚠️
app/export.go	50.00%	1 Missing ⚠️
tests/wasmibctesting/utils.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##           releases/v0.6x    #2250      +/-   ##
==================================================
+ Coverage           45.98%   46.00%   +0.01%     
==================================================
  Files                  78       79       +1     
  Lines               10685    10678       -7     
==================================================
- Hits                 4914     4912       -2     
+ Misses               5335     5332       -3     
+ Partials              436      434       -2

Files with missing lines	Coverage Δ
app/upgrades.go	`67.85% <ø> (-16.89%)`	⬇️
app/export.go	`9.67% <50.00%> (+0.30%)`	⬆️
tests/wasmibctesting/utils.go	`0.00% <0.00%> (ø)`
app/app.go	`86.59% <98.16%> (+1.35%)`	⬆️
app/upgrades/v060/upgrades.go	`0.00% <0.00%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

app/app.go

chipshort

LGTM, thanks for getting this done!
We can avoid the resource upgrade for the linter by upgrading to latest golangci-lint, but that can be handled separately (see #2269).

chipshort · 2025-05-26T10:24:28Z

We should also backport this to the main branch

pinosu · 2025-05-26T10:31:29Z

We should also backport this to the main branch

sure! should we get also the linter issue fixed in this PR so that when backported has already everything in place?

chipshort · 2025-05-26T10:35:37Z

sure! should we get also the linter issue fixed in this PR so that when backported has already everything in place?

Sure, we can do it like that too. I just rebased #2269 on this PR. It merges into here, so if you are happy with it, feel free to merge and then we can backport this whole PR.

* Remove deprecated golangci-lint configs * Update golangci-lint * Apply linter fixes

* Bump cosmos-sdk v0.53.0 * remove crisis module * fix simulations * Suppress lint errors * Fix golangci-lint warnings * Remove unnecessary loop copy * Updates * [autofix.ci] apply automated fixes * fix: Disable IAVL prunning to prevent dangling goroutines in tests * fix: Try to use newer golangci * Increase resources for lint * Update golangci-lint (#2269) * Remove deprecated golangci-lint configs * Update golangci-lint * Apply linter fixes --------- Co-authored-by: Christoph Otter <chris@confio.gmbh> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tomasz Kulik <tomek.kulik2@gmail.com>

Bump cosmos-sdk v0.53.0 (#2250) - main backport

* Make validateAddress cheaper if canonicalization fails (#2193) (cherry picked from commit cdb72b1) * feat(data): Make sure Aliases in DenomUnit is not nil (cherry picked from commit 69c38a5) * chore(comment): Add code comments (cherry picked from commit 1eaf666) * chore(test): Add test (cherry picked from commit 8473fea) * chore(comment): Improve comment clarity in query_plugins.go (cherry picked from commit e3df21e) * Restore file permission (cherry picked from commit 9eb5dd8) * Rename message args 💅 (#2207) * Rename args to `msg` consistently in WasmEngine interface * Rename file to wasm_engine.go "Wasmer" is an implementation detail that can change at any time (cherry picked from commit 1756d2d) * Use gas overflow error for ToWasmVMGas (cherry picked from commit dda8ea3) * Streamline Stargate/gRPC querier interfaces (#2093) * Change RejectStargateQuerier from factory function to free function * Clarify error message to help contract developers * Streamline and improve documentation for RejectGrpcQuerier * Pull out function signatures * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> (cherry picked from commit 146cdea) * Lower `DefaultMaxCallDepth` (#2244) * Lower DefaultMaxCallDepth * Add changelog entry * Fix test * Bump cosmos-sdk v0.53.0 (#2250) * Bump cosmos-sdk v0.53.0 * remove crisis module * fix simulations * Suppress lint errors * Fix golangci-lint warnings * Remove unnecessary loop copy * Updates * [autofix.ci] apply automated fixes * fix: Disable IAVL prunning to prevent dangling goroutines in tests * fix: Try to use newer golangci * Increase resources for lint * Update golangci-lint (#2269) * Remove deprecated golangci-lint configs * Update golangci-lint * Apply linter fixes --------- Co-authored-by: Christoph Otter <chris@confio.gmbh> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tomasz Kulik <tomek.kulik2@gmail.com> * Prepare changelog for release (#2274) * Prepare changelog for release * Update * Update wasmvm (cherry picked from commit d5d9860) * Fix tests (cherry picked from commit 8404057) * Update dockerfile (cherry picked from commit c51b4e4) * Fix * Improve readability * Fix * Restructure error handling * Add comments * Add setup cost for IBC operations * Fix tests * Use ExpectedJSONSize function --------- Co-authored-by: Christoph Otter <chris@confio.gmbh> Co-authored-by: BigtoC <taitocdt@gmail.com> Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tomasz Kulik <tomek.kulik2@gmail.com>

pinosu added 4 commits May 9, 2025 14:11

Bump cosmos-sdk v0.53.0

239b481

remove crisis module

ea59cda

fix simulations

3eab200

Suppress lint errors

0b96b9f

pinosu mentioned this pull request May 22, 2025

feat: Cosmos SDK v53 support #2206

Closed

pinosu requested review from chipshort and kulikthebird May 22, 2025 09:35

chipshort added 2 commits May 22, 2025 14:42

Fix golangci-lint warnings

39acb32

Remove unnecessary loop copy

d7d1657

chipshort reviewed May 22, 2025

View reviewed changes

kulikthebird requested a review from chipshort May 23, 2025 07:02

pinosu and others added 5 commits May 23, 2025 15:00

Updates

b7c6aef

[autofix.ci] apply automated fixes

7d69bcb

fix: Disable IAVL prunning to prevent dangling goroutines in tests

e478ad8

fix: Try to use newer golangci

e3fd472

Increase resources for lint

1eaa762

chipshort reviewed May 23, 2025

View reviewed changes

app/app.go Show resolved Hide resolved

chipshort approved these changes May 26, 2025

View reviewed changes

Update golangci-lint (#2269)

7a94243

* Remove deprecated golangci-lint configs * Update golangci-lint * Apply linter fixes

pinosu merged commit 15d0f29 into releases/v0.6x May 26, 2025
16 checks passed

pinosu deleted the bump_sdk_v53 branch May 26, 2025 13:42

chipshort added a commit that referenced this pull request Jun 2, 2025

Merge pull request #2273 from CosmWasm/backport_sdk_53

1eb978e

Bump cosmos-sdk v0.53.0 (#2250) - main backport

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bump cosmos-sdk v0.53.0 #2250

Bump cosmos-sdk v0.53.0 #2250

Uh oh!

pinosu commented May 9, 2025

Uh oh!

chipshort left a comment

Uh oh!

kulikthebird commented May 22, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

chipshort left a comment

Uh oh!

chipshort commented May 26, 2025

Uh oh!

pinosu commented May 26, 2025

Uh oh!

chipshort commented May 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Bump cosmos-sdk v0.53.0 #2250

Bump cosmos-sdk v0.53.0 #2250

Uh oh!

Conversation

pinosu commented May 9, 2025

Uh oh!

chipshort left a comment

Choose a reason for hiding this comment

Uh oh!

kulikthebird commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

chipshort left a comment

Choose a reason for hiding this comment

Uh oh!

chipshort commented May 26, 2025

Uh oh!

pinosu commented May 26, 2025

Uh oh!

chipshort commented May 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kulikthebird commented May 22, 2025 •

edited

Loading

codecov bot commented May 23, 2025 •

edited

Loading