Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject wasm zips exceeding limit #301

Closed
wants to merge 1 commit into from
Closed

Reject wasm zips exceeding limit #301

wants to merge 1 commit into from

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 5, 2020

Resolves #287

@alpe alpe requested a review from ethanfrey November 5, 2020 16:00
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #301 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   17.23%   17.29%   +0.05%     
==========================================
  Files          35       35              
  Lines       10463    10468       +5     
==========================================
+ Hits         1803     1810       +7     
+ Misses       8563     8562       -1     
+ Partials       97       96       -1     
Impacted Files Coverage Δ
x/wasm/internal/keeper/ioutil.go 100.00% <100.00%> (ø)
x/wasm/internal/keeper/keeper.go 90.21% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41cf73d...e55cc9f. Read the comment docs.

@alpe
Copy link
Contributor Author

alpe commented Nov 6, 2020

Included in #302

@alpe alpe closed this Nov 6, 2020
@alpe alpe deleted the code_limit_287 branch November 6, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return error if wasm to big
1 participant