Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom message handler option #402

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jan 29, 2021

Resolves #327

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #402 (2ac2b1e) into master (0f46dee) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   55.21%   55.43%   +0.21%     
==========================================
  Files          39       39              
  Lines        4015     4010       -5     
==========================================
+ Hits         2217     2223       +6     
+ Misses       1618     1608      -10     
+ Partials      180      179       -1     
Impacted Files Coverage Δ
x/wasm/internal/keeper/options.go 100.00% <100.00%> (+100.00%) ⬆️
x/wasm/internal/types/codec.go 38.46% <0.00%> (-2.72%) ⬇️
x/wasm/internal/keeper/keeper.go 88.91% <0.00%> (+0.83%) ⬆️

@alpe alpe requested a review from ethanfrey January 29, 2021 12:54
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Just exposing this with the options. Such a great design

@alpe alpe merged commit 4141cc3 into master Feb 1, 2021
@alpe alpe deleted the message_handler_option_327 branch February 1, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom MessageHandler in wasm
2 participants