Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cost and api cost options #533

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Add cost and api cost options #533

merged 1 commit into from
Jun 11, 2021

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jun 11, 2021

Resolves #525

I have started with public vars but stopped as this would open the door for concurrent access from outside the module. As a library we should protect against that. A simple but safe alternative are constructor Options. It was not in my original lists of proposals though.

@alpe alpe requested a review from ethanfrey June 11, 2021 09:55
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good approach to allow this to be configured in app.go without adding runtime overhead (db reads for params approach)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extendable gas costs
2 participants