Some examples/comments

[alpe]

Do not merge 🚨

Some examples from SDK and comments.

I would like to see examples of flattened events. I am worried now this may open the door for fraud. 🤷

[codecov]

Codecov Report

Merging #583 (fc88359) into events-docs (657b427) will increase coverage by 0.03%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           events-docs     #583      +/-   ##
===============================================
+ Coverage        59.67%   59.71%   +0.03%     
===============================================
  Files               45       45              
  Lines             5208     5208              
===============================================
+ Hits              3108     3110       +2     
+ Misses            1875     1874       -1     
+ Partials           225      224       -1     

Impacted Files	Coverage Δ
x/wasm/keeper/keeper.go	85.47% <0.00%> (+0.36%)	⬆️

[ethanfrey]

I would like to see examples of flattened events. I am worried now this may open the door for fraud. 🤷

They are only available via Tendermint (Cosmos SDK does not flatten).

If you have:

[
  { "type": "wasm", "attributes": [
    {"key": "_contract_address", "value": "12345"}, 
    {"key": "transfer", "value": "failed"}]},
  { "type": "wasm", "attributes": [
    {"key": "_contract_address", "value": "76543"}, 
    {"key": "transfer", "value": "success"}]}
]

This will end up in the Tendermint queries as:

[
  { "type": "wasm", "attributes": [
    {"key": "_contract_address", "value": "12345"}, 
    {"key": "transfer", "value": "failed"}]},
    {"key": "_contract_address", "value": "76543"}, 
    {"key": "transfer", "value": "success"}]}
]

If we tag each on with the _contract_address, the info is there and the onus is on the client to carefully parse. (Not just contract address is there and transfer=success is there, but the order.

That said, CosmJS has long considered this field unreliable and only returns events from parsing the log field, which has all proper data.

[ethanfrey]

Some response to your comments. Links to other parts of the sdk

[ethanfrey]

This is emitted on every transaction - https://github.com/cosmos/cosmos-sdk/blob/v0.42.9/x/auth/ante/sigverify.go#L103-L120 not so interesting for us but good to reference.

Also, it would make reading easier IMO if sdk.AttributeKeyModule was replaced by "module" or whatever. Anyone using events will need to find the strings for the client.

[ethanfrey]

And THIS is what I was thinking of when I mentioned AnteHandlers: https://github.com/cosmos/cosmos-sdk/blob/6888de1d86026c25197c1227dae3d7da4d41a441/baseapp/baseapp.go#L746-L748

msgEvents := sdk.Events{
			sdk.NewEvent(sdk.EventTypeMessage, sdk.NewAttribute(sdk.AttributeKeyAction, eventMsgName)),
		}
		msgEvents = msgEvents.AppendEvents(msgResult.GetEvents())

Unfortunately the calculation of that string changed between 0.42.9 and 0.43.0 (for new message service modules):

0.42.9: msgFqName = svcMsg.MethodName https://github.com/cosmos/cosmos-sdk/blob/v0.42.9/baseapp/baseapp.go#L709

0.43.0: eventMsgName = sdk.MsgTypeURL(msg) https://github.com/cosmos/cosmos-sdk/blob/v0.43.0-rc3/baseapp/baseapp.go#L720

It uses a longer URL. This did break relayers

[ethanfrey]

This is the same as above? Did you intend to link something else?

[alpe]

ja, first example should have been the message type. sorry

[ethanfrey]

Thanks for the input. Integrated feedback into #581 manually