Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade wasmvm-v1.0.0-soon2 #628

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Upgrade wasmvm-v1.0.0-soon2 #628

merged 3 commits into from
Oct 7, 2021

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Oct 6, 2021 •
edited
Loading

Resolves #624

  • Upgrades to v1.0.0-soon2
  • DefaultGasMultiplier set to 15_000_000

@alpe alpe requested a review from ethanfrey October 6, 2021 15:22
@codecov
Copy link

codecov bot commented Oct 6, 2021 •
edited
Loading

Codecov Report

Merging #628 (2719ee9) into master (5e88752) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #628   +/-   ##
=======================================
  Coverage   60.51%   60.51%           
=======================================
  Files          48       48           
  Lines        5270     5270           
=======================================
  Hits         3189     3189           
  Misses       1859     1859           
  Partials      222      222
Impacted Files Coverage Δ
x/wasm/keeper/gas_register.go 97.29% <ø> (ø)
app/app.go 84.01% <100.00%> (ø)

ethanfrey
ethanfrey approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

interesting the gas costs rose by exactly 1 almost everywhere? different rounding with the bigger numbers?

good to merge when the comment is fixed.

@alpe alpe merged commit 62e976a into master Oct 7, 2021
@alpe alpe deleted the 624-wasmvm_upgrade branch October 7, 2021 12:11
@fragwuerdig fragwuerdig mentioned this pull request Jan 23, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to wasmvm 1.0.0-soon2
3 participants
@alpe @webmaster128 @ethanfrey