Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Formatting update #648

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Go Formatting update #648

merged 3 commits into from
Oct 21, 2021

Conversation

fkneeland-figure
Copy link
Contributor

@fkneeland-figure fkneeland-figure commented Oct 14, 2021

Resolves: #649

The command make format makes a bunch of modifications. This pr just contains the changes from running the automatic go formatters.

@ethanfrey
Copy link
Member

Looks like a lot, and thanks for pulling this into a separate PR.

I will let @alpe review this when he is back.

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #648 (7235921) into master (d82a0b9) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
+ Coverage   60.21%   60.24%   +0.03%     
==========================================
  Files          48       48              
  Lines        5313     5313              
==========================================
+ Hits         3199     3201       +2     
+ Misses       1889     1888       -1     
+ Partials      225      224       -1     
Impacted Files Coverage Δ
app/ante.go 100.00% <ø> (ø)
app/app.go 84.01% <ø> (ø)
app/test_access.go 0.00% <ø> (ø)
app/test_helpers.go 0.86% <ø> (ø)
x/wasm/client/cli/genesis_msg.go 70.54% <ø> (ø)
x/wasm/client/cli/gov_tx.go 0.00% <ø> (ø)
x/wasm/client/cli/new_tx.go 0.00% <ø> (ø)
x/wasm/client/cli/query.go 0.00% <ø> (ø)
x/wasm/client/cli/tx.go 25.00% <ø> (ø)
x/wasm/handler.go 70.00% <ø> (ø)
... and 23 more

@alpe
Copy link
Contributor

alpe commented Oct 18, 2021

This will conflict with #645 as most files were touched there already. I would suggest to set this PR on hold and start fresh again after 645 is merged.

@fredkneeland
Copy link

@alpe I think it would be better if we merged this pr, as all the changes here are just automatic formatting change. Unfortunately, I added these commits to #645 as I didn't realize I would have to make a bunch of additional changes. So there won't be any merge conflicts if this is merged first, but it will greatly reduce the complexity of #645 as it won't have all these autoformatting changes added on top. Thanks!

@alpe
Copy link
Contributor

alpe commented Oct 21, 2021

We inherited the make format task from cosmos-sdk when the project was forked. It is good to have this cleanup up now. Thanks for your contribution.

@alpe alpe merged commit dd390d7 into CosmWasm:master Oct 21, 2021
faddat added a commit to notional-labs/wasmd that referenced this pull request Nov 27, 2021
* make fmt

* changelog update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto format the repo
4 participants