-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go Formatting update #648
Go Formatting update #648
Conversation
Looks like a lot, and thanks for pulling this into a separate PR. I will let @alpe review this when he is back. |
Codecov Report
@@ Coverage Diff @@
## master #648 +/- ##
==========================================
+ Coverage 60.21% 60.24% +0.03%
==========================================
Files 48 48
Lines 5313 5313
==========================================
+ Hits 3199 3201 +2
+ Misses 1889 1888 -1
+ Partials 225 224 -1
|
This will conflict with #645 as most files were touched there already. I would suggest to set this PR on hold and start fresh again after 645 is merged. |
@alpe I think it would be better if we merged this pr, as all the changes here are just automatic formatting change. Unfortunately, I added these commits to #645 as I didn't realize I would have to make a bunch of additional changes. So there won't be any merge conflicts if this is merged first, but it will greatly reduce the complexity of #645 as it won't have all these autoformatting changes added on top. Thanks! |
We inherited the |
* make fmt * changelog update
Resolves: #649
The command
make format
makes a bunch of modifications. This pr just contains the changes from running the automatic go formatters.